Skip to content

Add support for RP2040 GPIN/GPOUT (clkio) #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Add support for RP2040 GPIN/GPOUT (clkio) #9009

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d2b1b74
Add support for RP2040 GPIN/GPOUT (clkio)
tinylabs Mar 5, 2024
3b1a31a
Run make translate, remove whitespace
tinylabs Mar 5, 2024
2f31860
Fix code formatting
tinylabs Mar 6, 2024
128b8c4
Rename clkio to rp2clock
tinylabs Mar 22, 2024
c60fa3d
Update class names
tinylabs Mar 22, 2024
a5dd74c
Update formatting
tinylabs Mar 22, 2024
ee36308
Rebuild translations
tinylabs Mar 22, 2024
bb6a09e
Move to enum macro, make requested changes
tinylabs Apr 3, 2024
670df5c
Fix docs
tinylabs Apr 3, 2024
d35cda7
Update docs
tinylabs Apr 3, 2024
852814b
Fix doc formatting
tinylabs Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rebuild translations
  • Loading branch information
@tinylabs
tinylabs committed Mar 22, 2024
commit ee36308a1de82ef4a852ec1a8b1b5706a8b46678
28 changes: 14 additions & 14 deletions locale/circuitpython.pot
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to reuse messages in this file instead of adding new ones. That way there is less to translate and less to store in the firmware.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried my best to combine them on latest commits.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do all translations end up in every build regardless of the modules compiled in? I just assumed that these would only be pulled in when CIRCUITPY_RP2CLOCK=1. I can make the messages more generic to reuse them but we'd lose some information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only translations for enabled modules are included. I assume we'll have RP2CLOCK enabled for all RP2040 boards where it'll fit. Striking the generic vs specific balance can be tricky.

Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ msgstr ""
msgid "%q must be multiple of 8."
msgstr ""

#: ports/raspberrypi/bindings/clkio/ClkAuxSrc.c
#: ports/raspberrypi/bindings/clkio/ClkIndex.c
#: ports/raspberrypi/bindings/cyw43/__init__.c py/argcheck.c py/objexcept.c
#: ports/raspberrypi/bindings/cyw43/__init__.c
#: ports/raspberrypi/bindings/rp2clock/AuxSrc.c
#: ports/raspberrypi/bindings/rp2clock/Index.c py/argcheck.c py/objexcept.c
#: shared-bindings/bitmapfilter/__init__.c shared-bindings/canio/CAN.c
#: shared-bindings/digitalio/Pull.c shared-bindings/supervisor/__init__.c
#: shared-module/synthio/Synthesizer.c
Expand All @@ -228,8 +228,8 @@ msgstr ""
msgid "%q must be power of 2"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/clkio/ClkOutput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
#: ports/raspberrypi/common-hal/rp2clock/OutputPin.c
msgid "%q not set"
msgstr ""

Expand Down Expand Up @@ -1225,7 +1225,7 @@ msgstr ""
msgid "Invalid data_pins[%d]"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkOutput.c
#: ports/raspberrypi/common-hal/rp2clock/OutputPin.c
msgid "Invalid divisor: [1, 2-16777215]"
msgstr ""

Expand All @@ -1237,7 +1237,7 @@ msgstr ""
msgid "Invalid format chunk size"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
#, c-format
msgid "Invalid freqs: %u > %u"
msgstr ""
Expand Down Expand Up @@ -1669,12 +1669,12 @@ msgstr ""
msgid "Permission denied"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
#, c-format
msgid "Pin %d invalid, valid pins are: 20,22"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkOutput.c
#: ports/raspberrypi/common-hal/rp2clock/OutputPin.c
#, c-format
msgid "Pin %d invalid, valid pins are: 21,23,24,25"
msgstr ""
Expand All @@ -1687,8 +1687,8 @@ msgstr ""
msgid "Pin count too large"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/clkio/ClkOutput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
#: ports/raspberrypi/common-hal/rp2clock/OutputPin.c
msgid "Pin in use"
msgstr ""

Expand Down Expand Up @@ -2757,7 +2757,7 @@ msgstr ""
msgid "clip point must be (x,y) tuple"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
msgid "clock_configure_gpin failed!"
msgstr ""

Expand Down Expand Up @@ -3992,7 +3992,7 @@ msgstr ""
msgid "splitting with sub-captures"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
msgid "src freq == 0"
msgstr ""

Expand Down Expand Up @@ -4049,7 +4049,7 @@ msgstr ""
msgid "syntax error in uctypes descriptor"
msgstr ""

#: ports/raspberrypi/common-hal/clkio/ClkInput.c
#: ports/raspberrypi/common-hal/rp2clock/InputPin.c
msgid "target freq == 0"
msgstr ""

Expand Down