Skip to content

fix: French number parsing ambiguity #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Conversation

snowystinger
Copy link
Member

Closes #7866

Discussed with Adobe's globalization team and french CLDR contributor. The consensus was that periods are ambiguous. France started to have recommendations against using periods as group separators in 1948, however, it was still taught in schools for a long time. As a result, depending on age or where someone went to school, they may expect it to be the decimal or they may expect it to be the group separator. To get rid of the ambiguity, it was recommended that we remove period as an allowed character and expand the group separator characters to allow all kinds of spaces so that they can easily be typed out on a standard keyboard.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 19, 2025

@snowystinger snowystinger added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit cea861e Mar 29, 2025
30 checks passed
@snowystinger snowystinger deleted the fix-french-number-parsing branch March 29, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In french locale, useNumberField replace dot by non-breaking space instead of a comma
4 participants