-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: RSP storybook updates #8391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/badge/chromatic/Badge.stories.tsx # packages/@react-spectrum/card/stories/GalleryCardView.stories.tsx # packages/@react-spectrum/card/stories/GridCardView.stories.tsx # packages/@react-spectrum/card/stories/WaterfallCardView.stories.tsx # packages/@react-spectrum/color/stories/ColorWheel.stories.tsx # packages/@react-spectrum/label/chromatic/HelpText.stories.tsx # packages/@react-spectrum/label/stories/HelpText.stories.tsx # packages/@react-spectrum/list/stories/ListViewActions.stories.tsx # packages/@react-spectrum/list/stories/ListViewSelection.stories.tsx # packages/@react-spectrum/menu/chromatic/Submenu.stories.tsx # packages/@react-spectrum/table/stories/Table.stories.tsx # packages/@react-spectrum/table/stories/TreeGridTable.stories.tsx
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
## API Changes
@react-spectrum/overlays/@react-spectrum/overlays:OpenTransition OpenTransition {
-
+ UNTYPED
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to skim this but GitHub completely freezes and is unusable. So I trust you. 😄
Closes
Same test instructions as #8375
Keep in mind, most of this is internal stories and tests, my eyes are bleeding from checking all the stories, the AI's eyes are probably bleeding too.
I suggest focusing on the files in our
src
, you can go commit by commit, I did my best to break it up into manageable chunks so github can display meaningful diffs.I ran this PR against chromatic as well, it's green https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=968
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: