-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: hcm progress circle #8487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hcm progress circle #8487
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
default: `[${pxToRem(3)}]`, | ||
size: { | ||
S: 2, | ||
L: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these other values are converted to rems in the theme. Borders and strokes use pixels by default, but we chose to use rems for progress circle. So I think you will need to manually convert these too.
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:DragAndDropOptions DragAndDropOptions {
acceptedDragTypes?: 'all' | Array<string | symbol> = 'all'
dropTargetDelegate?: DropTargetDelegate
getAllowedDropOperations?: () => Array<DropOperation>
getDropOperation?: (DropTarget, DragTypes, Array<DropOperation>) => DropOperation
getItems?: (Set<Key>) => Array<DragItem> = () => []
isDisabled?: boolean
onDragEnd?: (DraggableCollectionEndEvent) => void
onDragMove?: (DraggableCollectionMoveEvent) => void
onDragStart?: (DraggableCollectionStartEvent) => void
onDrop?: (DroppableCollectionDropEvent) => void
onDropActivate?: (DroppableCollectionActivateEvent) => void
onDropEnter?: (DroppableCollectionEnterEvent) => void
onDropExit?: (DroppableCollectionExitEvent) => void
onInsert?: (DroppableCollectionInsertDropEvent) => void
onItemDrop?: (DroppableCollectionOnItemDropEvent) => void
onMove?: (DroppableCollectionReorderEvent) => void
onReorder?: (DroppableCollectionReorderEvent) => void
onRootDrop?: (DroppableCollectionRootDropEvent) => void
renderDragPreview?: (Array<DragItem>) => JSX.Element
- renderDropIndicator?: (DropTarget, Set<Key>, Key) => JSX.Element
+ renderDropIndicator?: (DropTarget) => JSX.Element
shouldAcceptItemDrop?: (ItemDropTarget, DragTypes) => boolean
} |
Closes RSP Component Milestones (view)
Like progress bar, the circle should be visible even when progress is close to 0, otherwise it can be invisible or hard to tell what it is. Do this by creating an inner and outer stroke for the circle.
Because SVG strokes are half in and half out of the shape (along the path), we can shrink the track by 2px to allow 1px on either side of that path using a hidden extra circle that's invisible in non-hcm cases.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: