Skip to content

fix: ActionGroup collapsed menu icons #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix: ActionGroup collapsed menu icons #8492

merged 1 commit into from
Jul 7, 2025
+3 −3

Conversation

snowystinger
Copy link
Member

Closes #6477

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 5, 2025

Build successful! 🎉

yihuiliao
yihuiliao approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe good idea to run chromatic?

@snowystinger snowystinger added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 655602f Jul 7, 2025
31 checks passed
@snowystinger snowystinger deleted the fix-actiongroup-collapsed-menu-icon branch July 7, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActionGroup Icon not provided padding when rendered with sibling and ActionGroup is collapsed
4 participants
@snowystinger @rspbot @reidbarber @yihuiliao