Skip to content

fix: tailwind starter storybook docs #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix: tailwind starter storybook docs #8493

merged 1 commit into from
Jul 7, 2025
+2 −2

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Jul 5, 2025 •
edited
Loading

Closes

When building the tailwind starter locally the docs page for components were not working.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Jul 5, 2025
Closed
@rspbot
Copy link

rspbot commented Jul 5, 2025

Build successful! 🎉

LFDanLu
LFDanLu approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the before and after tailwind storybook locally

yihuiliao
yihuiliao approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the storybook locally

@snowystinger snowystinger added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 2e8838c Jul 7, 2025
32 checks passed
@snowystinger snowystinger deleted the fix-tailwind-starter-docs-pages branch July 7, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LFDanLu LFDanLu LFDanLu approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @rspbot @LFDanLu @yihuiliao