-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Warn correct state usage for modals #8495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, wonder if we should additionally add this information in the modal's "isDismissible"/"isOpen"/etc prop descriptions so they are readily available in an IDE's autocomplete so people can catch this even earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add a process.env.NODE_ENV !== 'production'
check here
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:FileTrigger FileTrigger {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void /react-aria-components:FileTriggerProps FileTriggerProps {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void @react-spectrum/filetrigger/@react-spectrum/filetrigger:FileTrigger FileTrigger {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void /@react-spectrum/filetrigger:FileTriggerProps FileTriggerProps {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void @react-spectrum/s2/@react-spectrum/s2:FileTrigger FileTrigger {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void /@react-spectrum/s2:FileTriggerProps FileTriggerProps {
acceptDirectory?: boolean
- acceptedFileTypes?: ReadonlyArray<string>
+ acceptedFileTypes?: Array<string>
allowsMultiple?: boolean
children?: ReactNode
defaultCamera?: 'user' | 'environment'
onSelect?: (FileList | null) => void |
Closes #6547, #6277
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: