Skip to content

chore: S2 docs followup #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2025
Merged

chore: S2 docs followup #8504

merged 6 commits into from
Jul 7, 2025

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Jul 7, 2025

Minor cleanup for the s2 docs:

  • make 'ArrowDown' open the SearchMenu onKeyDown
  • fix chevron in SearchMenu's trigger action button
  • fix Github logo
  • header/menu layout improvements

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 7, 2025

@rspbot
Copy link

rspbot commented Jul 7, 2025

## API Changes

react-aria-components

/react-aria-components:useContextProps

 useContextProps <E extends Element, T, U extends SlotProps> {
   props: (T & SlotProps)
-  ref: ForwardedRef<E> | undefined
+  ref: ForwardedRef<E>
   context: Context<ContextValue<U, E>>
   returnVal: undefined
 }

@reidbarber reidbarber added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 8891825 Jul 7, 2025
32 checks passed
@reidbarber reidbarber deleted the s2-docs-followup branch July 7, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants