feat: Prevent onChange from firing in TextFields while user is typing via IME #8519
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is for IMEs, we only want onChange to fire once the user has confirmed the final word/phrase they wanna enter
| return; | ||
| } | ||
|
|
||
| onChangeProp && onChangeProp(val); |
There was a problem hiding this comment.
Suggested change
| onChangeProp && onChangeProp(val); | |
| onChangeProp?.(val); |
|
Build successful! 🎉 |
deleting IME input is essentially cancelling it so it shouldnt trigger another onChange
snowystinger
approved these changes
Jul 10, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8506
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP