fix: S2 Prevented Tooltip text overflowing by default #8527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -167,7 +167,7 @@ export const Tooltip = forwardRef(function Tooltip(props: TooltipProps, ref: DOM | |||
| placement={placement} | |||
| shouldFlip={shouldFlip} | |||
| ref={tooltipRef} | |||
| style={UNSAFE_style} | |||
| style={{overflowWrap: 'break-word', ...UNSAFE_style}} | |||
There was a problem hiding this comment.
you'll want to add this style to the tooltip style (classname one line below is where that is used, it's a style macro), not to the inline style for the element
See https://react-spectrum.adobe.com/s2/index.html?path=/docs/style-macro--docs for more info on style macros
There was a problem hiding this comment.
I considered that, but currently there isn't support there for overflowWrap in React Spectrum v3 and S2. Is this an addition we want to add support for here, and would that require additional documentation changes etc?
There was a problem hiding this comment.
yeah, looks like the comment suggests we should add it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8514
✅ Pull Request Checklist:
📝 Test Instructions:
Create a Tooltip with long non-breaking text
Before:
After:
🧢 Your Project: