-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Support async loading in S2 TreeView #8528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build successful! 🎉 |
0173b66
to
6faaa71
Compare
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you run chromatic on this?
@@ -66,6 +68,16 @@ const meta: Meta<typeof TreeView> = { | |||
} | |||
}, | |||
table: {category: 'Events'} | |||
}, | |||
isDetached: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, got a bit confused here, the comments on those props made it sound like they weren't fully implemented yet but I see that its more that a combination of the two + selection isn't working. I'll add descriptions and add them back in
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:DragAndDropOptions DragAndDropOptions {
acceptedDragTypes?: 'all' | Array<string | symbol> = 'all'
dropTargetDelegate?: DropTargetDelegate
getAllowedDropOperations?: () => Array<DropOperation>
getDropOperation?: (DropTarget, DragTypes, Array<DropOperation>) => DropOperation
getItems?: (Set<Key>) => Array<DragItem> = () => []
isDisabled?: boolean
onDragEnd?: (DraggableCollectionEndEvent) => void
onDragMove?: (DraggableCollectionMoveEvent) => void
onDragStart?: (DraggableCollectionStartEvent) => void
onDrop?: (DroppableCollectionDropEvent) => void
onDropActivate?: (DroppableCollectionActivateEvent) => void
onDropEnter?: (DroppableCollectionEnterEvent) => void
onDropExit?: (DroppableCollectionExitEvent) => void
onInsert?: (DroppableCollectionInsertDropEvent) => void
onItemDrop?: (DroppableCollectionOnItemDropEvent) => void
onMove?: (DroppableCollectionReorderEvent) => void
onReorder?: (DroppableCollectionReorderEvent) => void
onRootDrop?: (DroppableCollectionRootDropEvent) => void
- renderDragPreview?: (Array<DragItem>) => JSX.Element | {
- element: JSX.Element
- x: number
- y: number
-}
+ renderDragPreview?: (Array<DragItem>) => JSX.Element
renderDropIndicator?: (DropTarget, Set<Key>, Key) => JSX.Element
shouldAcceptItemDrop?: (ItemDropTarget, DragTypes) => boolean
} @react-aria/dnd/@react-aria/dnd:DragPreviewProps DragPreviewProps {
- children: (Array<DragItem>) => JSX.Element | {
- element: JSX.Element
- x: number
- y: number
-} | null
+ children: (Array<DragItem>) => JSX.Element | null
} /@react-aria/dnd:DragPreview DragPreview {
- children: (Array<DragItem>) => JSX.Element | {
- element: JSX.Element
- x: number
- y: number
-} | null
+ children: (Array<DragItem>) => JSX.Element | null
} @react-spectrum/s2/@react-spectrum/s2:TreeViewLoadMoreItem+TreeViewLoadMoreItem {
+ loadingState?: LoadingState
+ onLoadMore?: () => any
+} /@react-spectrum/s2:TreeViewLoadMoreItemProps+TreeViewLoadMoreItemProps {
+ loadingState?: LoadingState
+ onLoadMore?: () => any
+} |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: