fix: Mark copies of Parcel storybook packages as private #8530
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
reidbarber
approved these changes
Jul 11, 2025
yihuiliao
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes verdaccio build.
Parcel packages for Storybook were copied into our repo for SB 8 work, but we forgot to mark them as private. Looks like we've been publishing nightly versions of them from our repo instead of the real one for a while 😬.
Additionally, they don't get version bumped by the verdaccio script, so when it goes to publish it conflicts with the existing version on npm and errors. Unfortunately this does not seem to fail the Circle CI build, which then moves on to the v-docs step. That proceeds to install the latest version from npm rather than the actual verdaccio build (which was never published). And now this fails during the build because we depend on new exports that aren't there in the current npm release.