add Nim SDK #29
add Nim SDK #29
Conversation
|
Hey @jasagiri, thanks for the contribution. |
tylerslaton
added
the
Roadmap
|
Hey @jasagiri, would you be up for maintaining this if it's merged? |
|
I've never collaborated with VSC before, so I'm still feeling my way around, but I can do it. |
There was a problem hiding this comment.
Hi @jasagiri! This looks great. Left a small comment about the documentation. Outside of that, a few asks.
- Since this is older, can you look through the existing protocol spec and make sure this is fully compatible?
- Can you run the tests in CI? We'd happily accept a contribution for that.
- How would we go about packaging this for Nim's consumption?
There was a problem hiding this comment.
Can we please add documentation to the docs folder and get rid of this? We don't necessarily want to keep these files.
There was a problem hiding this comment.
Can you please remove this? Also in the root would you mind adding a gitignore for this?
There was a problem hiding this comment.
Same thing here, can we remove this?
There was a problem hiding this comment.
Lets make sure to remove all of these please!
There was a problem hiding this comment.
Looks like these AI generated files also go in. Can we remove them? CLAUDE.md is good to keep but let's remove the progress ones.
maxkorp
requested review from
NathanTarbert,
ataibarkai,
maxkorp,
mme and
ranst91
as code owners
4 participants
add Nim SDK