-
Notifications
You must be signed in to change notification settings - Fork 258
Made Data.Container(.Any/.FreeMonad)
safe by splitting out fixed points
#1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am perversely tempted to suggested adding a sized version of the I can prepare the commits doing that & push it to this PR if you |
It seems that atm there are different choices of greatest fp for indexed vs. non-indexed:
I think it would make sense to have all four variants in each case, as @gallais suggests:
|
Will be fixed by PR agda/agda-stdlib#1513.
Yup, happy to have all the variants included if you want to update the PR @gallais |
Multiplicity of choice, in this case, seems like a good idea to me as well. |
@gallais are you going to have time to look at this today? Otherwise let me know and I'll have a crack at it, as I think we'd probably better make a 2nd release candidate sooner rather than later. |
Yep, doing it today during AIM. |
This is ready I think. But please merge #1517 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to summarise the comments, I think the most consistent structure would be:
Data.Container(.Indexed).Fixpoint.(Sized/Guarded)
?
where the Guarded
modules re-export the least fixpoints that live in Data.Container(.Indexed)
?
Fixes #1466