Regression: ForContext API doesn't apply changes

[Aaronontheweb]

Looks like I broke this in v1.3.6

[alexvaut]

I don't think this is fixing the issue. With the "new" keyword, calling Error(...) on a ILoggingAdapter is going to call BusLogging.Error and not SerilogLoggingAdapter.Error. The methods in BusLogging should be marked virtual. The only workaround I found is to cast the ILoggingAdapter instance to a SerilogLoggingAdapter and then call Error on it.

[albertich]

Same problem. The rollback to version 1.3.3 has helped.

[Aaronontheweb]

@albertich yeah, I'll go ahead and submit my fixes aimed at resolving this in the main Akka.NET project

[Aaronontheweb]

Working on restoring the functionality described here - should have a repro spec that demonstrates that this does / does not work shortly: #33

[Aaronontheweb]

Repro spec here: #52

Validates the work-around suggested by @nekenk1, but also proves that the current solution is broken out of the box. Going to be patching Akka.NET to fix this at the ILoggingAdapter level.

[Aaronontheweb]

Not actually closed yet - need to release Akka.NET v1.3.9 and then merge this in.

[ondrejpialek]

With Akka 1.3.9 hot off the press is this issue now resolved or does it need code changes here too?