PR for beta.8

[aksonov]

• Fix: ‘clone’ scenes declared at the end were not visible for scenes declared above
• Enhancement: If component has static navigationOptions return it instead of RNRF generated options
• Enhancement: Allow all navBar properties (title, right, left, rightButtonImage, onRight, etc.) be defined as static functions/values of Scene component
• Fix: Actions.refresh was broken because navigationStore doesn’t allow the same scene after state change
• Enhancement: fix ESLint errors for tests
• Fix: avoid re-render of all scenes during navigation state change (Constant rerendering of scenes in the stack.  #2018)
• Support rightButtonTextStyle and leftButtonTextStyle, avoid reset them to default values after push (after push from Login to Login2, "Cancel" became blue again)
• Fix: Support passing navbar attributes (like onRight/onLeft/leftTitle/rightTitle) via Actions.refresh
• Fix: postinstall somewhere doesn't work with npm (Failed at the [email protected] postinstall script 'opencollective postinstall'. #2008)

[compojoom]

@aksonov - how is this fixing the actions.refresh? I downloaded the 4.0.8 branch and launched the example, but I still can't change the title on the login page.

The same happens in a separate project as well.

[aksonov]

@compojoom Please check now (forgot to 'build' js)

[compojoom]

@aksonov - it seems to partially work. It's changing the title, but nothing more? I was used to the folowing pattern in v3:

componentDidMount() {
		console.log('wtffff refressshshhh');
		let title = 'Analyse1',
			rightTitle = 'Speichern';

		if (this.props.editMode) {
			title = 'Analyse Bearbeiten';
			rightTitle = 'Fertig';
		}
		Actions.refresh({
			title: title,
			rightTitle: rightTitle,
			onRight: () => this.onRight(),
			backTitle: 'Abbrechen',
		});
	}

this seems to work now, but the only thing changing is the title. No right button appears in my navbar.

[compojoom]

Hm, okay. Defining onRight and rightTitle on my scene seems to work together with refresh. If I define them on the scene, refresh will override them, but if I don't define them, then nothing happens. I don't see any right button.

[aksonov]

@compojoom Please check with latest commit.

[southerneer]

I tried adding static nav options on Example/components/Register.js and they weren't overriding the RNRF options... Example.js is currently using beta.7

[southerneer]

I put the Echo view at the bottom of the router component to test clones and RNRF choked on the JSON.stringify call. When I commented it out it worked great...adding a commit.

[southerneer]

All the other changes/fixes seemed to work for me!

[compojoom]

I'm wondering if anyone else is experiencing this:

I just open and re-save the image, but I don't understand why this happens at all.

[compojoom]

@aksonov - if the scene doesn't have onright and rightTitle, then the refresh action isn't working. (tested with latest version)

[aksonov]

@compojoom Please give me link to forked Example to demonstrate.

[aksonov]

@southerneer Thanks!

[aksonov]

@compojoom Never mind, was able to reproduce with your snippet above

[compojoom]

@aksonov - you were faster https://github.com/compojoom/react-native-router-flux/tree/4.0.0-beta.8-no-refresh

[aksonov]

@compojoom Check now

[aksonov]

About burger image, use Issues search. Like #703

[compojoom]

woooohoooo! Let's open the champagne bottle for PR8 👍

Everything seems to work

[aksonov]

@compojoom Thanks for testing!