Skip to content

fix(specs): message is not required in WatchResponse #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 7, 2025

🧭 What and Why

🎟 JIRA Ticket: CR-8231

The message is not returned by the push task endpoint when watcher=false.
However the runID should be always returned.

@millotp millotp requested a review from a team as a code owner April 7, 2025 10:48
@millotp millotp requested review from morganleroi and Fluf22 April 7, 2025 10:48
@millotp millotp self-assigned this Apr 7, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 7, 2025

✔️ Code generated!

Name Link
🪓 Triggered by eb2beb96961fe20684323eaa3c99875f061f4a94
🍃 Generated commit 6486bfc04ada174244df6ba97b9f48c204e6d0cd
🌲 Generated branch generated/fix/watcher-message
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1676
go 1555
php 1419
csharp 1334
java 1122
python 1030
ruby 819
swift 460
scala 23

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@millotp millotp merged commit e150cd9 into main Apr 7, 2025
28 checks passed
@millotp millotp deleted the fix/watcher-message branch April 7, 2025 12:30
algolia-bot added a commit that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Apr 7, 2025
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants