Improve readability of examples in verlet.cpp #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mika314
commented
Jul 12, 2018
mika314
commented
- make functions return time
- assign value to vars at declaration
- use next_pos var name instead of tmp_pos (delete comment)
Gathros
added
the
Implementation Edit
- make functions return time - assign value to vars at declaration - use next_pos var name instead of tmp_pos (delete comment)
Contributor
Author
|
BUMP |
leios
approved these changes
Jul 15, 2018
Member
leios
left a comment
leios
left a comment
There was a problem hiding this comment.
These changes are ultimately positive.
This was referenced Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.