Skip to content

Conversation

@berquist
Copy link
Member

  • bug that caused sorting order to be reversed
  • spaces after commas
  • Julia v1 has shuffle! in the Random package. I don't know how long the transitional period to 1.0 is, but is it a problem if this doesn't work with < 1.0?

- bug that caused sorting order to be reversed
- spaces after commas
- Julia v1 has shuffle! in the Random package
@leios
Copy link
Member

leios commented Sep 14, 2018

I can take a look at the shuffle function soon. Thanks for the heads-up!

@june128 june128 added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Sep 14, 2018
@Butt4cak3
Copy link
Contributor

Julia v1 has shuffle! in the Random package. I don't know how long the transitional period to 1.0 is, but is it a problem if this doesn't work with < 1.0?

We're not targeting a production environment here. It's more important that the code examples are relevant and up-to-date, so I'd say go with it if it's possible in the newest version or else the code in the book will be outdated earlier than necessary.

@leios
Copy link
Member

leios commented Sep 21, 2018

I don't mind the changes in this PR, but I agree with @Butt4cak3 , if shuffle is in julia V1.0, we can use it. So far as I see, we were using the shuffle!() function already, so were you asking about how to make this compatible with Julia 0.4 or something?

@leios
Copy link
Member

leios commented Sep 22, 2018

I have been going through and updating the julia code for V1.0. Since you already have this PR up, do you mind just adding a using Random at the start of the file?

@berquist
Copy link
Member Author

I was asking if it would be a problem that code samples would not longer work with < v1, because of course Arch updated very quickly, but really no one should be using < v1 and the Julia team would be the first to say that.

Since you already have this PR up, do you mind just adding a using Random at the start of the file?

https://github.com/algorithm-archivists/algorithm-archive/pull/379/files#diff-748545546903a491988fbfcecff0171fR1

@leios
Copy link
Member

leios commented Sep 22, 2018

oops. That was my bad. I missed that line somehow. Let me check build this locally, then it's good to go.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Thanks for the change!

@leios leios merged commit 838ae9d into algorithm-archivists:master Sep 22, 2018
@berquist berquist deleted the bogo-sort-julia branch September 22, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants