Java filename changes for Verlet / bogosort / bubblesort #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation Edit
leios
approved these changes
Jan 23, 2019
Member
leios
left a comment
leios
left a comment
There was a problem hiding this comment.
Looks good. If this helps out with the development, then it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was setting up IntelliJ to work with Kotlin, and I had to make some changes to get it to stop complaining about these Java implementations.
Most notable is that public classes should be in their own files, hence the new
VerletValues.java.There is still a complaint about
VerletValuesexisting in both Kotlin and Java (because they both compile to a JVM class of the same name), but that's safe to ignore.