Moves permutation importance from evalml/pipeline/utils.py to graph_utils.py #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 195 195
Lines 8503 8505 +2
=======================================
+ Hits 8482 8484 +2
Misses 21 21
Continue to review full report at Codecov.
|
dsherry
reviewed
Jun 24, 2020
dsherry
reviewed
Jun 24, 2020
docs/source/changelog.rst
Outdated
| @@ -39,6 +40,7 @@ Changelog | |||
| **Breaking Changes** | |||
| * Pipelines' static ``component_graph`` field must contain either ``ComponentBase`` subclasses or ``str``, instead of ``ComponentBase`` subclass instances :pr:`850` | |||
| * Rename ``handle_component`` to ``handle_component_class``. Now standardizes to ``ComponentBase`` subclasses instead of ``ComponentBase`` subclass instances :pr:`850` | |||
| * ``calculate_permutation_importances`` and ``graph_permutation_importances`` were moved from `evalml.pipeline.utils` to `evalml.pipeline.graph_utils` :pr:`880` | |||
There was a problem hiding this comment.
Since we haven't released this yet, no need to add to breaking changes.
Also, perhaps you can just add the PR number to the end of the previous entry in "Enhancements" for #860
dsherry
approved these changes
Jun 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #875