Skip to content

chore: stub in new Analytics-Node-AI package #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

daniel-graham-amplitude
Copy link
Collaborator

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Copy link

promptless bot commented Jul 7, 2025

✅ No documentation updates required.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Import Mismatch Causes Prototype Inheritance Test Failure

The test file incorrectly imports OpenAI as a named export (import { OpenAI as OpenAIOriginal } from 'openai'). The openai package (v5.x) provides OpenAI as a default export. This import mismatch prevents OpenAIOriginal in the test from correctly referencing the base class, causing the prototype inheritance test to fail.

packages/analytics-node-ai/src/openai.ts#L1-L1

import OpenAIOriginal from 'openai';

packages/analytics-node-ai/test/openai.test.ts#L1-L2

/* eslint-disable no-prototype-builtins */
import { OpenAI as OpenAIOriginal } from 'openai';

Fix in CursorFix in Web


Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎

@daniel-graham-amplitude daniel-graham-amplitude changed the base branch from main to v1.x July 7, 2025 22:24
@daniel-graham-amplitude daniel-graham-amplitude changed the base branch from v1.x to main July 7, 2025 22:25
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-graham-amplitude daniel-graham-amplitude changed the base branch from main to hackathon-llm July 7, 2025 22:40
@daniel-graham-amplitude daniel-graham-amplitude merged commit 37d6994 into hackathon-llm Jul 8, 2025
10 checks passed
@daniel-graham-amplitude daniel-graham-amplitude deleted the hackathon-llm-sdk branch July 8, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants