Skip to content

introducing isMuted #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

introducing isMuted #5

wants to merge 1 commit into from

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Jan 15, 2018

Adding a isMuted option to the measuring parameters: its purpose is, basically, to not print any logs for that component is the option is set to true.

The overall idea of this option is to use it in combo with the startRecording/printRecording methods without seeing every single component render log while using it.

Slightly OT, is this a good way to approach the start/print?

    constructor() {
      setTimeout(() => {
        ReactPerformance.startRecording()
        setTimeout(() => {
          ReactPerformance.printRecording()
        }, 20000)
      }, 100)
    }

(I mean, using setTimeout in the constructor for a component)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant