Fix routing annotation #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change port from 8889 to standard 80 Replace LoadBalancer with ClusterIP Shorten route to exclude model name
amygdala
reviewed
Dec 6, 2018
| value: DATA_DIR | ||
| ports: | ||
| - name: http-server | ||
| containerPort: 8080 |
Owner
There was a problem hiding this comment.
This needs to remain 8080 -- it's the (hardwired) port of the gunicorn server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change port from 8889 to standard 80
Replace LoadBalancer with ClusterIP
Shorten route to exclude model name