Skip to content

Conversation

@sararob
Copy link
Collaborator

@sararob sararob commented Jul 16, 2021

Made a few minor updates to this notebook:

  • Replaced AI Platform with Vertex AI
  • Added more info on getting TensorBoard set up in Vertex

If there are other updates you think this needs, lmk and I can work on them. Also, I may add more detail on why you'd want to use training option 1 vs. 2.

@amygdala
Copy link
Owner

amygdala commented Jul 25, 2021

Sorry, somehow I missed this! I am mid-process of making some other changes, let me finish merging them in first, then look the conflicts that I apparently introduced with your PR. Thanks for doing this!

@amygdala
Copy link
Owner

amygdala commented Jul 25, 2021

I believe the issue is that when I was making some other notebook edits, I introduced some global formatting/indentation changes by switching from colab to jupyterlab as my notebook editor. I think it may be too much of a pain to resolve conflicts in the usual way as essentially the whole notebook is the diff 😬. The changes all look great. I think it will be easier to create a new PR off HEAD that re-adds them. Shall I do that, then ping you? (sorry about this).

@sararob
Copy link
Collaborator Author

sararob commented Jul 28, 2021

No prob! Yes, probably easier for me to create a new PR. Just let me know when your changes are ready.

@amygdala
Copy link
Owner

amygdala commented Aug 2, 2021

other PR is in, closing this. Thanks, Sara.

@amygdala amygdala closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants