Add AspectRatioFrameLayout for PlayerView so video is properly sized within video player when first set #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within video player when first set
calren
force-pushed
the
caren/fix_video_size_fit
branch
from
1788957 to
a091ba2
Compare
|
@droid-girl Can you take a quick look at this fix for video being properly sized / fitted? Or feel free to tag someone from ExoPlayer team. Thanks! |
2 tasks
|
As mentioned in #172, this is only a workaround for a Compose related issue that should be resolved in the 1.4.0-rc01 release of Media3, so I will close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172