combined 2 guard clauses

[humzashah]

Two guard clauses have been combined into one. Previously one clause
was checking for the object's existence, the other was checking for
its attributes. Now the same guard clause chains the conditions
together thereby reducing a code line.

[nmccready]

This can be shorter via, return unless value?.lng and value?.lat

[humzashah]

@nmccready, nice! isn't as readable though. plus it checks for the existence of value twice. to clarify:

original code:
return if value is undefined
return if value doesn't have a lng or it doesn't have a ltd

my code:
return unless there is a value defined with lng and ltd

your code:
return unless value is defined and has a lng and value is defined and has a lat

what do u say?

[nmccready]

I wouldn't say it is less readable, if your used to coffee this is a goto staple for me know. It eliminates tons of redundant code.

Also unless I normally use only if there is one variable to check for truthyness but your case works cause your using a bunch of ands. Basically unless has unexpected behavior at times where it really means if !(value and value.lng and value.lat).

Anyway this one liner is not worth arguing about.

[nmccready]

Actually this would have been best return unless value?.lng and value.lat then one check for existence and it satisfies me and u.

[humzashah]

good point, @nmccready ! :)