Example doesn't work with newest version: AngularFireUploadTask.downloadURL(); returns undefined

[takahser]

Version info

Angular: "^5.2.1"
Firebase: "^5.0.2"
AngularFire: "5.0.0-rc.7"

It used to work on earlier versions, e.g.:
"angularfire2": "5.0.0-rc.6",
"firebase": "^5.0.2",

How to reproduce these conditions

See the example Monitoring upload percentage

@Component({
  selector: 'app-root',
  template: `
    <input type="file" (change)="uploadFile($event)" />
    <div>{{ uploadPercent | async }}</div>
    <a [href]="downloadURL | async">{{ downloadURL | async }}</a>
 `
})
export class AppComponent {
  uploadPercent: Observable<number>;
  downloadURL: Observable<string>;
  constructor(private storage: AngularFireStorage) {}
  uploadFile(event) {
    const file = event.target.files[0];
    const filePath = 'name-your-file-path-here';
    const task = this.storage.upload(filePath, file);
    
    // observe percentage changes
    this.uploadPercent = task.percentageChanges();
    // get notified when the download URL is available
    this.downloadURL = task.downloadURL();
  }
}

Expected behavior

On the current version, when uploading a file using AngularFireStorage.upload(filePath, file) the downloadUrl of the file can be requested by subscribing to AngularFireUploadTask.downloadURL():

AngularFireUploadTask.downloadURL().subscribe(console.log) // should log download url

Actual behavior

Instead of returning the URL, the subscription returns undefined:

AngularFireUploadTask.downloadURL().subscribe(console.log) // logs undefined

[jamesdaniels]

Firebase 5.0 removed downloadUrl from upload task, so we did so too. I'll rework the doc.

[takahser]

@jamesdaniels thanks for the info. Did they replace it with something else or can't we use this functionality anymore?

[jamesdaniels]

You need to use downloadUrl on the ref.

…

On Mon, May 14, 2018, 6:31 PM S E R A Y A ***@***.***> wrote: @jamesdaniels <https://github.com/jamesdaniels> thanks for the info. Did they replace it with something else or can't we use this functionality anymore? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1645 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACvr4oDTTjULjyfeztdQkxPizfo_L_cks5tyi_ggaJpZM4T-C61> .

[takahser]

@jamesdaniels thanks for your advice, this is actually what I tried however, in my case I'm uploading a file and I'd like to get the download url as soon as the file is uploaded. Even if I wait with requesting the file after it was uploaded (I tried wait for the AngularFireStorage.upload to be fulfilled), we have race conditions, since at this time the firebase storage service won't necessarily have processed the new image and therefore I get a 404. The only way I was able to make it work in a "reliable" way was by using setTimeout which is obviously very ugly... Is there a better way to do this?

[jamesdaniels]

@takahser see Jeff's comment #1649 (comment)

[jamesdaniels]

Docs have been updated.

[Lx]

The table in the updated docs still references getDownloadURL as an available method on AngularFireUploadTask, which doesn't seem to be the case.