Skip to content

Don't cache ngsw-config.json in firebase hosting #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgechev opened this issue Dec 5, 2019 · 1 comment
Closed

Don't cache ngsw-config.json in firebase hosting #2259

mgechev opened this issue Dec 5, 2019 · 1 comment
Labels
type: chore

Comments

@mgechev
Copy link
Member

mgechev commented Dec 5, 2019

Version info

Angular:

latest

Firebase:

latest

AngularFire:

latest

Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

For any project run:

ng add @angular/fire

If the app is a PWA it'll have ngsw-config.json, which firebase will cache for an hour.

Expected behavior

Add the file to the cache ignore list.

Thanks to @abraham for mentioning this today on the Modern Web meetup.
@jamesdaniels jamesdaniels mentioned this issue Sep 16, 2021
Merged
@jamesdaniels
Copy link
Member

Addressed in the upcoming AngularFire 7.1 release

jamesdaniels added a commit that referenced this issue Sep 16, 2021
@jamesdaniels
fix(schematics): Various improvements (#2961)
dd414b2 
* Support multiple package managers on ng deploy, fixes #2841
* Don't cache ngsw, fixes #2259
* Got rid os AppCheck debug token on Node, opted for a better pattern in `samples/advanced`
* Added a new pattern for connecting the emulators in `samples/advanced`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesdaniels @mgechev