-
Notifications
You must be signed in to change notification settings - Fork 4
Move the dialogs to the ADR code base #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is a draft. I want to get your guys opinion about this approach before going through the exercise of doing it for all the dialogs in this file (looks like the problem is only with this file). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 80.14% 80.32% +0.17%
==========================================
Files 25 25
Lines 7061 7048 -13
Branches 1330 1323 -7
==========================================
+ Hits 5659 5661 +2
+ Misses 983 970 -13
+ Partials 419 417 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pydynamic reporting side. We're removing some dialogs and putting them into ADR code base to allow for translation.