Skip to content

Move the dialogs to the ADR code base #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

margalva
Copy link
Collaborator

@margalva margalva commented May 1, 2025

pydynamic reporting side. We're removing some dialogs and putting them into ADR code base to allow for translation.

@margalva margalva requested a review from viseshrp as a code owner May 1, 2025 19:48
@margalva margalva marked this pull request as draft May 1, 2025 19:48
@margalva margalva requested review from zhang-yuanrui and dcansys May 1, 2025 19:49
@margalva
Copy link
Collaborator Author

margalva commented May 1, 2025

This is a draft. I want to get your guys opinion about this approach before going through the exercise of doing it for all the dialogs in this file (looks like the problem is only with this file).

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (fbc3b59) to head (c8af751).

Files with missing lines Patch % Lines
...ynamicreporting/core/utils/report_remote_server.py 5.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   80.14%   80.32%   +0.17%     
==========================================
  Files          25       25              
  Lines        7061     7048      -13     
  Branches     1330     1323       -7     
==========================================
+ Hits         5659     5661       +2     
+ Misses        983      970      -13     
+ Partials      419      417       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants