Skip to content

chore: sync JSON Schema from APISIX version 2.3 #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Feb 6, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

sync JSON Schema from APISIX version 2.3

@codecov-io
Copy link

codecov-io commented Feb 6, 2021

Codecov Report

Merging #1445 (8655986) into master (8796fa1) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
+ Coverage   67.61%   67.88%   +0.26%     
==========================================
  Files          48       48              
  Lines        3042     3042              
==========================================
+ Hits         2057     2065       +8     
+ Misses        741      733       -8     
  Partials      244      244              
Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 47.27% <0.00%> (+3.63%) ⬆️
api/internal/core/store/storehub.go 74.48% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8796fa1...8655986. Read the comment docs.

@membphis
Copy link
Member

membphis commented Feb 6, 2021

frontend e2e failed

@membphis
Copy link
Member

membphis commented Feb 6, 2021

ping @LiteSun

@LiteSun
Copy link
Member

LiteSun commented Feb 7, 2021

The reason why the front-end e2e hangs is because the authz-keycloak schema is updated, the front-end needs to update the test data of the authz-keycloak plugin. will fix it soon.

image

@juzhiyuan juzhiyuan merged commit 5348579 into apache:master Feb 7, 2021
@nic-chen nic-chen deleted the jsonschema-2.3 branch February 7, 2021 07:01
@imjoey
Copy link
Member

imjoey commented Feb 7, 2021

@juzhiyuan @starsz This PR needs to be backported to v2.4 branch for release 2.4.

@imjoey imjoey self-assigned this Feb 7, 2021
imjoey pushed a commit to imjoey/apisix-dashboard that referenced this pull request Feb 7, 2021
liuxiran pushed a commit that referenced this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants