Skip to content

fix: modify the rpm link for 2.4 #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

fix: modify the rpm link for 2.4 #1497

merged 1 commit into from
Feb 23, 2021

Conversation

liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Feb 22, 2021 •
edited by juzhiyuan
Loading

Please answer these questions before submitting a pull request

@juzhiyuan juzhiyuan requested a review from imjoey February 22, 2021 22:11
bzp2010
bzp2010 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
😁

@juzhiyuan juzhiyuan merged commit f574fcd into apache:master Feb 23, 2021
@juzhiyuan
Copy link
Member

Need update v2.4 too :)

@liuxiran
Copy link
Contributor Author

liuxiran commented Mar 1, 2021

Need update v2.4 too :)

Sorry for taking so long to notice this information.
I noticed that branch V2.4 has already been removed together with other released version branches, I just want to make sure that we don't maintain these branches until it becomes a LTS version right? @juzhiyuan

@juzhiyuan
Copy link
Member

image

Hi, could you have a recheck?

@liuxiran
Copy link
Contributor Author

liuxiran commented Mar 2, 2021

image

Hi, could you have a recheck?

Found it, it is not fully displayed on my phone, sorry.

liuxiran added a commit to liuxiran/apisix-dashboard that referenced this pull request Mar 2, 2021
@liuxiran
fix: modify the rpm link for 2.4 (apache#1497)
4b3b1b9
@liuxiran liuxiran mentioned this pull request Mar 2, 2021
Merged
4 tasks
juzhiyuan pushed a commit that referenced this pull request Mar 2, 2021
@liuxiran
fix: modify the rpm link for 2.4 (#1497) (#1537)
623b803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@imjoey imjoey Awaiting requested review from imjoey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken RPM download link
3 participants
@liuxiran @juzhiyuan @bzp2010