ATLAS-5029 : Connected export : When multiple entities are exported ,… #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not all of its connected entities are exported
mandarambawane
requested review from
pinal-shah,
chaitalicod,
mneethiraj and
rkundam
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with exporting connected entities where not all related entities were properly exported. It adds new tests in ExportServiceTest.java to cover connected export scenarios and introduces logic changes in ExportService.java and RelationshipAttributesExtractor.java to better handle the starting entity in the export process.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java | Adds new tests and data provider to verify connected export behavior and proper import processing via ImportService. |
| repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java | Updates connected fetch logic to exclude the starting entity from duplicate processing. |
| repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java | Introduces a startingEntityGuid to resume processing for the starting entity and adjusts the export traversal loop accordingly. |
Comments suppressed due to low confidence (2)
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java:292
- Consider adding an inline comment here explaining the purpose of the resumeExportForStartingEntity flag to enhance code clarity during export processing of the starting entity.
if ((context.fetchType == ExportFetchType.CONNECTED ...
repository/src/main/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractor.java:56
- [nitpick] A short comment explaining the rationale behind resetting the traversal direction for the starting entity could improve clarity for reviewers and maintainers.
if (context.startingEntityGuid.equals(entity.getGuid())) {
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
Show resolved
Hide resolved
…portService.java Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not all of its connected entities are exported
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. ATLAS-XXXX: Fix a typo in YYY))
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)