Support Snowflake - allow number as placeholder (e.g. :1)
#1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6639508164
💛 - Coveralls |
Contributor
Author
|
@alamb I add failed test and refactored the PR to identify numbers only within placeholder. |
alamb
approved these changes
Oct 25, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @yuval-illumex -- this makes sense to me
| Token::Placeholder(ref s) => Ok(Value::Placeholder(s.to_string())), | ||
| tok @ Token::Colon | tok @ Token::AtSign => { | ||
| let ident = self.parse_identifier()?; | ||
| // Not calling self.parse_identifier()? because only in placeholder we want to check numbers as idfentifies |
Contributor
There was a problem hiding this comment.
✅ makes sense to me
Suggested change
| // Not calling self.parse_identifier()? because only in placeholder we want to check numbers as idfentifies | |
| // Not calling self.parse_identifier()? because only in placeholder we want to check numbers as identifiers |
alamb
changed the title
:1)
alamb
changed the title
:1):1)
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following query is valid in snowflake:
SELECT :1 from table