Support quoted identifiers in AST as well #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
force-pushed
the
quote-id-quote
branch
from
61d8cfc to
b1cbc55
Compare
Contributor
|
Thanks, Robert, this looks great! No review feedback whatsoever. I'm |
The Ident type was previously an alias for a String. Turn it into a full fledged struct, so that the parser can preserve the distinction between identifier value and quote style already made by the tokenizer's Word structure.
Pull Request Test Coverage Report for Build 480
💛 - Coveralls |
Author
|
Good to hear that it was acceptable. And thank you for doing the cleanup. I have CLion configured to rustfmt on Save but it appears to be unreliable. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #140, the tokenizer already handles quoted identifiers but the current AST drops that information onto the floor again. This pull request adds the same kind of quoted identifier support to the AST, replacing the
Identtype alias forStringwith a struct that closely resemblesWord. The changes are relatively small, with most lines uplifting the tests.This pull request closes #140. I am out of office next week (i.e., the one starting Monday 10/21). So please feel free to merge (or to make minor changes).