fix: Set the current folder as a "primary" for the find command
#2120
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing the 0.60,0 RC2 release I noticed the following at the end
of the logs:
```
find -iname Cargo.toml
find: illegal option -- i
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
```
The reason is the missing `.` before the arguments.
https://github.com/martin-g/datafusion-sqlparser-rs/blob/5a3b63bf419ff80e6acdb0b3bbdbcf664083f1d5/dev/release/verify-release-candidate.sh#L75
does it correctly
iffyio
approved these changes
Dec 3, 2025
alamb
approved these changes
Dec 3, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @martin-g 🙏
I tested this locally by running
./dev/release/verify-release-candidate.sh 0.60.0 2And it works great
When I ran the same thing on main I see
+ find -iname Cargo.toml
+ xargs grep SNAPSHOT
find: illegal option -- i
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
+ popd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the 0.60,0 RC2 release I noticed the following at the end of the logs:
The reason is the missing
.before the arguments.https://github.com/martin-g/datafusion-sqlparser-rs/blob/5a3b63bf419ff80e6acdb0b3bbdbcf664083f1d5/dev/release/verify-release-candidate.sh#L75 does it correctly