Skip to content

Conversation

@ever0de
Copy link
Contributor

@ever0de ever0de commented Aug 19, 2021

Implement the following cases

  • TRIM([BOTH | LEADING | TRAILING] <expr> [FROM <expr>])
  • TRIM(<expr>)

I referred to link

@ever0de ever0de changed the title Support TRIM syntax [WIP] Support TRIM syntax Aug 19, 2021
@ever0de ever0de changed the title [WIP] Support TRIM syntax Support TRIM syntax Aug 19, 2021
- Implement the following cases
- TRIM([BOTH | LEADING | TRAILING] <expr> [FROM <expr>])
- TRIM(<expr>)
- Remove needless borrow
@coveralls
Copy link

coveralls commented Aug 19, 2021

Pull Request Test Coverage Report for Build 1147491245

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 37 (89.19%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 90.107%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_postgres.rs 1 99.68%
src/parser.rs 2 86.06%
tests/sqlparser_common.rs 7 98.66%
Totals Coverage Status
Change from base Build 1040258090: -0.09%
Covered Lines: 5492
Relevant Lines: 6095

💛 - Coveralls

@Dandandan Dandandan merged commit e548d38 into apache:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants