Skip to content

Enhance flaky test TestRemoveUserCbHandlerOnPathRemoval #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

kaisun2000
Copy link
Contributor

@kaisun2000 kaisun2000 commented Jun 18, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #1102
TestRemoveUserCbHandlerOnPathRemoval has a flaky test

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Assert .assertEquals(watchPaths.get("existWatches").size(), 2, "Should have 2 exist-watches: CURRENTSTATE/{oldSessionId} and CURRENTSTATE/{oldSessionId}/TestDB0");
is flaky.

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

This test case pass. This pull only touch test case logic.

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Addres
the assertion in this diff.
Copy link
Contributor

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisun2000
Copy link
Contributor Author

This PR is ready to be merged, approved by @jiajunwang

Fix flaky test testRemoveUserCbHandlerOnPathRemoval # #1102

TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Addres
the assertion in this diff.

@jiajunwang jiajunwang merged commit 511dd3d into apache:watcher Jun 19, 2020
kaisun2000 added a commit to kaisun2000/helix that referenced this pull request Jun 23, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff.

Co-authored-by: Kai Sun <[email protected]>
jiajunwang pushed a commit that referenced this pull request Jun 24, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff.

Co-authored-by: Kai Sun <[email protected]>
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff.

Co-authored-by: Kai Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants