Support Concurrency Safety Validation: Implement `validateDeletedDataFiles` #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sungwy opened this issue Apr 18, 2025 · 0 comments · Fixed by #1938

Collaborator

sungwy commented Apr 18, 2025 •

edited

Loading

There's been a lot of continued interest in using multiple PyIceberg applications concurrently and having proper support for optimistic concurrency.

I think the best place to start is through the implementation of the individual validation functions

This subtask tracks the implementation of validateDeletedDataFiles function. The Java Reference implementation can be found here

The text was updated successfully, but these errors were encountered:

sungwy changed the title Implement validateDeletedDataFiles: [Java Reference](https://github.com/apache/iceberg/blob/9fc49e187069c7ec2493ac0abf20f73175b3df89/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L618-L636) Support Concurrency Safety Validation: Implement validateDeletedDataFiles

jayceslesar mentioned this issue

feat: validate_deleted_data_files #1938

Merged

Fokko closed this as completed in #1938

Fokko added a commit that referenced this issue


          feat: validate_deleted_data_files (#1938)

e98f685

Closes #1928 

# Rationale for this change
Add `validate_deleted_data_files` which depends on #1935 

# Are these changes tested?
Added a test!

# References

Java `deletedDataFiles` impl:

https://github.com/apache/iceberg/blob/3a29199e73f2e9ae0f8f92a1a0732a338c66aa0d/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L678

Java `ManifestGroup.entries` impl:

https://github.com/apache/iceberg/blob/3a29199e73f2e9ae0f8f92a1a0732a338c66aa0d/core/src/main/java/org/apache/iceberg/ManifestGroup.java#L242

---------

Co-authored-by: Fokko Driesprong <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment