Skip to content

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 27, 2025

Less is more!

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

self.io,
manifest,
partition_evaluators[manifest.partition_spec_id],
residual_evaluators[manifest.partition_spec_id],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

residual_evaluator is not used and needed since _build_metrics_evaluator below creates a _InclusiveMetricsEvaluator

def _build_metrics_evaluator(self) -> Callable[[DataFile], bool]:
schema = self.table_metadata.schema()
include_empty_files = strtobool(self.options.get("include_empty_files", "false"))
# The lambda created here is run in multiple threads.
# So we avoid creating _InclusiveMetricsEvaluator methods bound to a single
# shared instance across multiple threads.
return lambda data_file: _InclusiveMetricsEvaluator(
schema,
self.row_filter,
self.case_sensitive,
include_empty_files,
).eval(data_file)

@kevinjqliu kevinjqliu merged commit bdb7c7d into apache:main Feb 27, 2025
7 checks passed
@Fokko Fokko added this to the PyIceberg 0.9.1 milestone Apr 4, 2025
@Fokko Fokko deleted the fd-cleanup-unused-arg branch April 17, 2025 12:35
Fokko added a commit that referenced this pull request Apr 17, 2025
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants