Skip to content

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 15, 2025

Rationale for this change

Intermediate fix while the test is broken, reported in duckdb/duckdb-iceberg#185

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu
Copy link
Contributor

unblocks CI :)

@Fokko Fokko merged commit eb8756a into apache:main Apr 15, 2025
7 checks passed
@Fokko
Copy link
Contributor Author

Fokko commented Apr 15, 2025

unblocks CI :)

Indeed! :D

Thanks for the quick review @kevinjqliu 🙌

@Fokko Fokko deleted the fd-ignore-test branch April 15, 2025 18:41
kevinjqliu added a commit to kevinjqliu/iceberg-python that referenced this pull request Apr 17, 2025
Fokko pushed a commit that referenced this pull request Apr 17, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
Issue is fixed upstream,
duckdb/duckdb-iceberg#185

This reverts commit eb8756a. (#1918)

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
# Rationale for this change

Intermediate fix while the test is broken, reported in
duckdb/duckdb-iceberg#185

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
Issue is fixed upstream,
duckdb/duckdb-iceberg#185

This reverts commit eb8756a. (apache#1918)

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants