Skip to content

Conversation

kevinjqliu
Copy link
Contributor

Rationale for this change

poetry.lock file is generated with poetry 2.1.1
I suspect this is from dependabot. I couldn't find a way to control the version of poetry dependabot uses, so let's just match the version its using.
This way updating the lock file locally wont create a bunch of unrelated changed

Are these changes tested?

Are there any user-facing changes?

@kevinjqliu kevinjqliu requested a review from Fokko April 22, 2025 17:03
@Fokko Fokko merged commit b85127e into apache:main Apr 22, 2025
7 checks passed
@Fokko
Copy link
Contributor

Fokko commented Apr 22, 2025

Nice one, thanks @kevinjqliu

@kevinjqliu kevinjqliu deleted the kevinjqliu/update-poetry-version branch July 20, 2025 00:37
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
[`poetry.lock`
file](https://github.com/apache/iceberg-python/blob/59742e01e8d190aa759e0154b03300bd81a28d02/poetry.lock#L1)
is generated with poetry 2.1.1
I suspect this is from dependabot. I couldn't find a way to control the
version of poetry dependabot uses, so let's just match the version its
using.
This way updating the lock file locally wont create a bunch of unrelated
changed


# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants