-
Notifications
You must be signed in to change notification settings - Fork 326
maint: catalog implementation roundtripping tests #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
maint: catalog implementation roundtripping tests #2090
Conversation
@kevinjqliu @Fokko thoughts here? I think would be pretty light work to set up a common test suite for all catalogs Some immediate open questions:
|
Good call @jayceslesar 🙌
I'm not sure if I understand the question correctly, but let me give it a try. I'd prefer to avoid mock and rely on the integration tests that we have with the rest and hive image. The rest container is updated daily from the Java repository, and will let us know if something incompatible changes. |
Amazing -- I will take a stab at consolidating the testing of all main catalog behavior in an integration test |
Ok check out the latest commit. All integration tests. Looks like unable to run locally because im missing Edit: Also the aws creds but I trust that this is all configured in CI and I just can't see it which is fine, so if we are happy with the little setup I have I can expand it to cover all common behavior |
@kevinjqliu can you please trigger tests again? Just want to see everything hopefully work |
In pursuit of #813