Skip to content

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jun 20, 2025

In #2125 we got a warning from the google-auth package, and we're on 1.6.3 while 2.40.3 is out there. So maybe good to bump everything 👍

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

In apache#2125 we got a warning
from the google-auth package, and we're on `1.6.3` while `2.40.3`
is out there.
@Fokko Fokko requested a review from kevinjqliu June 20, 2025 07:09
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kevinjqliu kevinjqliu merged commit 2170fba into apache:main Jun 20, 2025
10 checks passed
Fokko pushed a commit that referenced this pull request Jun 20, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes #2124

# Rationale for this change
Refactor `Makefile` 
* Grouped commands and added comments
* Added `COVERAGE` param to run test with coverage
* Added `COVERAGE_FAIL_UNDER` param to specify coverage threshold to
pass
* Change test coverage threshold to `85` for unit tests, we are
currently at `87`
* Change test coverage threshold to `75` for integration tests, we are
currently at `77`

CI 
* Add s3/adls/gcs integration tests to run in CI
* Run tests with coverage report

Note the `gcsfs` issue was resolved by #2127

# Are these changes tested?
Yes

# Are there any user-facing changes?
No

<!-- In the case of user-facing changes, please add the changelog label.
-->
amitgilad3 pushed a commit to amitgilad3/iceberg-python that referenced this pull request Jul 7, 2025
In apache#2125 we got a warning
from the google-auth package, and we're on `1.6.3` while `2.40.3` is out
there. So maybe good to bump everything 👍

<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
amitgilad3 pushed a commit to amitgilad3/iceberg-python that referenced this pull request Jul 7, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes apache#2124

# Rationale for this change
Refactor `Makefile` 
* Grouped commands and added comments
* Added `COVERAGE` param to run test with coverage
* Added `COVERAGE_FAIL_UNDER` param to specify coverage threshold to
pass
* Change test coverage threshold to `85` for unit tests, we are
currently at `87`
* Change test coverage threshold to `75` for integration tests, we are
currently at `77`

CI 
* Add s3/adls/gcs integration tests to run in CI
* Run tests with coverage report

Note the `gcsfs` issue was resolved by apache#2127

# Are these changes tested?
Yes

# Are there any user-facing changes?
No

<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
In apache#2125 we got a warning
from the google-auth package, and we're on `1.6.3` while `2.40.3` is out
there. So maybe good to bump everything 👍

<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change

# Are these changes tested?

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes apache#2124

# Rationale for this change
Refactor `Makefile` 
* Grouped commands and added comments
* Added `COVERAGE` param to run test with coverage
* Added `COVERAGE_FAIL_UNDER` param to specify coverage threshold to
pass
* Change test coverage threshold to `85` for unit tests, we are
currently at `87`
* Change test coverage threshold to `75` for integration tests, we are
currently at `77`

CI 
* Add s3/adls/gcs integration tests to run in CI
* Run tests with coverage report

Note the `gcsfs` issue was resolved by apache#2127

# Are these changes tested?
Yes

# Are there any user-facing changes?
No

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants