revert avro timestamp-millis mapping #2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
moving this forward to unblock 0.10 release |
amogh-jahagirdar
approved these changes
Jul 22, 2025
geruh
approved these changes
Jul 22, 2025
|
thanks for the review @amogh-jahagirdar @geruh |
|
Late to the party here. Sorry @matthias-Q for seeing your work reverted, but I agree that it is the right thing to do. Maybe we can introduce other helper methods to safely do the up-casting of millis to micros. |
|
No worries, I understand that. I am also willing to help with the feature request issue. Just need a little guidance. |
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to apache#2173, the conversion as implemented is not safe since
iceberg does not natively have `millis` precision. Timestamp values are
implicitly in `micros` precision
This is confirmed by
apache#2173 (comment)
Let's revert for now and follow up to figure out the right way to
support `millis` precision.
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to #2173, the conversion as implemented is not safe since iceberg does not natively have
millisprecision. Timestamp values are implicitly inmicrosprecisionThis is confirmed by #2173 (comment)
Let's revert for now and follow up to figure out the right way to support
millisprecision.Are these changes tested?
Are there any user-facing changes?