Skip to content

Conversation

ehsantn
Copy link
Contributor

@ehsantn ehsantn commented Jul 30, 2025

As title. Closes #2258. Updated the lockfile just in case but it didn't change the Arrow version.

Rationale for this change

PyIceberg doesn't need this upper bound since it uses stable public APIs of PyArrow (as far as I can tell).

Dependency version upper bounds are known to be problematic:

  1. Cause cascading dependency conflicts
  2. Block security and bug fixes
  3. Limit user flexibility

In my case, this causes issues for Bodo's Arrow upgrades since both Arrow and PyIceberg are dependencies.

Are these changes tested?

Existing tests.

Are there any user-facing changes?

None except allowing newer PyArrow versions.

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM We dont need to restrict pyarrows upperbound, this also allows end users to try out newer releases of pyarrow

@ehsantn
Copy link
Contributor Author

ehsantn commented Jul 30, 2025

I just fixed an error with azurite on CI.

ports:
- 10000:10000
command: ["azurite-blob", "--loose", "--blobHost", "0.0.0.0"]
command: ["azurite-blob", "--loose", "--skipApiVersionCheck", "--blobHost", "0.0.0.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinjqliu kevinjqliu merged commit 904c0b7 into apache:main Jul 30, 2025
10 checks passed
@kevinjqliu
Copy link
Contributor

thank you @ehsantn

gabeiglio pushed a commit to Netflix/iceberg-python that referenced this pull request Aug 13, 2025
<!--
Thanks for opening a pull request!
-->
As title. Closes apache#2258. Updated the lockfile just in case but it didn't
change the Arrow version.

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change

PyIceberg doesn't need this upper bound since it uses stable public APIs
of PyArrow (as far as I can tell).

Dependency version upper bounds are known to be problematic:
1. Cause cascading dependency conflicts
2. Block security and bug fixes
3. Limit user flexibility

In my case, this causes issues for Bodo's Arrow upgrades since both
Arrow and PyIceberg are dependencies.

# Are these changes tested?

Existing tests.

# Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
None except allowing newer PyArrow versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] remove pyarrow upperbound

2 participants