Skip to content

Conversation

ayushjariyal
Copy link
Contributor

issue #2341

In this PR, I update ruff-pre-commit (updating v0.11.13 -> v0.12.9) in .pre-commit-config.yaml file and verify it with running make lint command.

Screenshot from 2025-08-20 13-57-32

@ayushjariyal
Copy link
Contributor Author

@Fokko, Can you please review this PR?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I often we have formatting changes as well with newer versions of Ruff. Thanks again @ayushjariyal

@ayushjariyal
Copy link
Contributor Author

@Fokko , I've updated the ruff formatting by runnig:

poetry run ruff check . --fix

Please let me know if I missed anything or if further adjustments are needed.

@ayushjariyal ayushjariyal requested a review from Fokko August 20, 2025 10:07
@Fokko
Copy link
Contributor

Fokko commented Aug 20, 2025

@ayushjariyal Typically we run make lint, which will also include the --fix argument.

We don't want to touch the content under vendor/ since that contains generated code that we don't want to alter. Could you revert these changes?

@ayushjariyal
Copy link
Contributor Author

@Fokko , Apologies for the earlier incorrect updates. I’ve now reverted the changes.

@Fokko
Copy link
Contributor

Fokko commented Aug 20, 2025

@ayushjariyal No problem at all, happens to the best of us 👍

@Fokko Fokko merged commit b647f72 into apache:main Aug 20, 2025
10 checks passed
@ayushjariyal ayushjariyal deleted the bump-ruff-pre-commit branch August 21, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants