Add fallback attribute to all strip_options.
#708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-derived `TypedBuilder` traits in combination with `strip_option`
attributes are very hard to use in scenarios where options passed to the
builder depend on user input. The problem is that this pattern doesn't
work, since the two match branches return different types:
```rust
let builder = match x {
None => builder,
Some(x) => builder.x(x),
};
```
Fortunately typed_builder 0.20 supports an additional attribute
(`fallback`) that generates a builder method that takes `Option<T>` in
addition to the method that takes naked `T`.
With this attribute, we can write `let builder = builder.x_opt(x)`.
This commit adds the `fallback` attribute to all fields that have the
`strip_option` annotation.
Signed-off-by: Leonid Ryzhyk <[email protected]>
liurenjie1024
approved these changes
Nov 26, 2024
shaeqahmed
pushed a commit
to matanolabs/iceberg-rust
that referenced
this pull request
Dec 9, 2024
Auto-derived `TypedBuilder` traits in combination with `strip_option`
attributes are very hard to use in scenarios where options passed to the
builder depend on user input. The problem is that this pattern doesn't
work, since the two match branches return different types:
```rust
let builder = match x {
None => builder,
Some(x) => builder.x(x),
};
```
Fortunately typed_builder 0.20 supports an additional attribute
(`fallback`) that generates a builder method that takes `Option<T>` in
addition to the method that takes naked `T`.
With this attribute, we can write `let builder = builder.x_opt(x)`.
This commit adds the `fallback` attribute to all fields that have the
`strip_option` annotation.
Signed-off-by: Leonid Ryzhyk <[email protected]>
Co-authored-by: Leonid Ryzhyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-derived
TypedBuildertraits in combination withstrip_optionattributes are very hard to use in scenarios where options passed to the builder depend on user input. The problem is that this pattern doesn't work, since the two match branches return different types:Fortunately typed_builder 0.20 supports an additional attribute (
fallback) that generates a builder method that takesOption<T>in addition to the method that takes nakedT.With this attribute, we can write
let builder = builder.x_opt(x).This commit adds the
fallbackattribute to all fields that have thestrip_optionannotation.