-
Notifications
You must be signed in to change notification settings - Fork 14.5k
MINOR: Add 4.0 branch to CI #18215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Add 4.0 branch to CI #18215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to extend the cancel-in-progress
logic to check for refs/heads/4.0
as well.
We can probably leave the two "gradle-cache-" properties as they are. This will effectively disable the cache on release branches, but since we are already at our cache usage limit so this is probably desired.
Edit: actually we'll want gradle-cache-read-only
to be true for release branches, so that will need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the two Gradle cache properties, we'll get
gradle-cache-read-only: true
gradle-cache-write-only: false
for 4.0
. This means we'll load the closest matching cache (the branch point, I guess?) which will basically mean starting from scratch (which is fine). Since we have many fewer builds and PRs for release branches, we can probably disable caching altogether for release branches. That doesn't need to happen in this PR though.
LGTM
Reviewers: David Arthur <[email protected]>
We also need to update the release process document to include this step, and remove the jenkins configuration section. |
Reviewers: David Arthur <[email protected]>
Add 4.1 branch to CI per #18215 Reviewers: Chia-Ping Tsai <[email protected]>
Committer Checklist (excluded from commit message)