Skip to content

MINOR: Add 4.0 branch to CI #18215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

MINOR: Add 4.0 branch to CI #18215

merged 4 commits into from
Dec 16, 2024

Conversation

dajac
Copy link
Member

@dajac dajac commented Dec 16, 2024

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac requested a review from mumrah December 16, 2024 14:45
@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Dec 16, 2024
@dajac dajac mentioned this pull request Dec 16, 2024
3 tasks
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to extend the cancel-in-progress logic to check for refs/heads/4.0 as well.

We can probably leave the two "gradle-cache-" properties as they are. This will effectively disable the cache on release branches, but since we are already at our cache usage limit so this is probably desired.

Edit: actually we'll want gradle-cache-read-only to be true for release branches, so that will need to be updated

Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the two Gradle cache properties, we'll get

gradle-cache-read-only: true
gradle-cache-write-only: false

for 4.0. This means we'll load the closest matching cache (the branch point, I guess?) which will basically mean starting from scratch (which is fine). Since we have many fewer builds and PRs for release branches, we can probably disable caching altogether for release branches. That doesn't need to happen in this PR though.

LGTM

@mumrah mumrah merged commit 86f7fde into apache:trunk Dec 16, 2024
7 checks passed
mumrah pushed a commit that referenced this pull request Dec 16, 2024
@dajac dajac deleted the add-4.0-ci branch December 17, 2024 07:37
@mimaison
Copy link
Member

We also need to update the release process document to include this step, and remove the jenkins configuration section.

tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Yunyung pushed a commit to Yunyung/kafka that referenced this pull request Jul 6, 2025
chia7712 pushed a commit that referenced this pull request Jul 7, 2025
Add 4.1 branch to CI per #18215

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants