KAFKA-18267: Add unit tests for CloseOptions #19571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
frankvicky
force-pushed
the
1092-follow-up
branch
from
62e794f to
b1cb889
Compare
frankvicky
force-pushed
the
1092-follow-up
branch
from
b1cb889 to
3017aa3
Compare
chia7712
reviewed
May 1, 2025
| @@ -84,10 +77,7 @@ public static CloseOptions timeout(final Duration timeout) { | |||
| * @return a new {@code CloseOptions} instance with the specified group membership operation. | |||
| */ | |||
| public static CloseOptions groupMembershipOperation(final GroupMembershipOperation operation) { | |||
There was a problem hiding this comment.
Could you please add unit test for it?
FrankYang0529
approved these changes
May 2, 2025
frankvicky
changed the title
chia7712
approved these changes
May 3, 2025
shmily7829
pushed a commit
to shmily7829/kafka
that referenced
this pull request
May 7, 2025
There is some redundant code that could be removed in `CloseOptions`. This patch also adds unit tests for CloseOptions. Reviewers: Ken Huang <[email protected]>, PoAn Yang <[email protected]>, Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some redundant code that could be removed in
CloseOptions.This patch also adds unit tests for CloseOptions.
Reviewers: Ken Huang [email protected], PoAn Yang
[email protected], Chia-Ping Tsai [email protected]